Measure with transform bugfix#44821
Closed
realsoelynn wants to merge 1 commit into
Closed
Conversation
Summary: Changelog: [Internal] - Originally D37994809 was attempted to fix `Inverted FlatList` but was put behind Feature Toggle because it was causing problems in other scenarios. - Later, D45866231 which was trying to fix scaling transform issue helped solve the issue attempted by the original diff. - But after that points, Unit test around `computeRelativeLayoutMetrics` was having two variants where Feature Toggle for D37994809 was checked in with a wrong expected value. - This diff revert D37994809 changes and clean up the unit test. Differential Revision: D58197918
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D58197918 |
Base commit: b5fd041 |
Contributor
|
This pull request has been merged in 0d34569. |
|
This pull request was successfully merged by @realsoelynn in 0d34569. When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Inverted FlatListbut was put behind Feature Toggle because it was causing problems in other scenarios.computeRelativeLayoutMetricswas having two variants where Feature Toggle for D37994809 was checked in with a wrong expected value.Differential Revision: D58197918